Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add preact cli e2e test #2958

Merged
merged 2 commits into from
Jun 1, 2021
Merged

ci: add preact cli e2e test #2958

merged 2 commits into from
Jun 1, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 30, 2021

What's the problem this PR addresses?

Preact CLI has PnP support now so we should have an e2e test to cover it
preactjs/preact-cli#1418

How did you fix it?

Added a test

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner May 30, 2021 08:39
@merceyz merceyz force-pushed the merceyz/ci/preact branch from e164688 to 7321e5e Compare May 30, 2021 08:41
@merceyz merceyz mentioned this pull request May 30, 2021
Closed
@arcanis arcanis enabled auto-merge (squash) June 1, 2021 08:11
@arcanis arcanis merged commit c417e22 into master Jun 1, 2021
@arcanis arcanis deleted the merceyz/ci/preact branch June 1, 2021 08:12
@merceyz merceyz mentioned this pull request Jun 3, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis arcanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis